Bugfix/sql put data unicode to bytes memory leak #832
Conversation
|
Hi @Mizaro I believe that if you apply this patch file to your branch … … it should get rid of the merge conflict with the current master branch at |
|
Hey @Mizaro - Any chance that you could apply the .gitignore patch in my previous comment? @mkleehammer might be more inclined to merge the PR if he doesn't have to mess around with conflicts. (I tried to submit the change as a PR to your fork, but GitHub wouldn't let me. I could submit PRs to a whole bunch of other forks, but yours wasn't among them. I've encountered the same issue in the past, but I don't understand why it happens.) |
|
@gordthompson I will do it! Just not today 😅 |
Updated .gitignore Added test for the Issue Convert to bytes to make code more readable and work make the memory leak bigger :) deref objCell if it was assigned to be bytes that was created from unicode cell info
|
Manually squashed and rebased. Thanks! |
|
@mkleehammer, Thanks for inserting it :) |
|
@gordthompson Thanks for being so proactive ! |
|
Hello, guys! Can you confirm if this issues has already been deployed? I am having something really similar, but my version is the newest 4.0.32 I read the Relases notes and didn't find anything related to #832 |
|
@thealbres - This patch was merged as 716572a on 2021-01-21 and included in version 4.0.31, released 2021-07-03. |
This is a fix to prevent the memory leak from Issue #802
In my investigation of the code's behavior, It seems that when there is a need to convert Unicode string to bytes, the newly created objects of bytes will never get dereference, thus staying in memory.